-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More build updates #429
Merged
Merged
More build updates #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-ABI builds are intended only for embeddded systems such as HWW/homebrew devices, and aren't supported by wrapped languages. Note that the tests for this configuration are supported; users can still verify the library functionality for this build config.
Use the now-exposed transaction member accessors so that the test does not rely on the binary layout of the transaction struct which changes when the Elements ABI is disabled.
jgriffiths
force-pushed
the
build_fixes
branch
4 times, most recently
from
October 31, 2023 13:17
34d27b7
to
9b1d0a1
Compare
Notably, secp no longer uses a generated config header, and embedded builds need to #define the modules they wish to use. Remove unused config #define references, and use warning #pragmas to avoid warnings rather than dummy functions. For the windows build/batch files, build using the amalgamation rather than having to define a large number of config defines on the command line. Use the above changes to greatly simplify both windows wheel builds and building wally as a DLL.
We only need our config.h and the swig wrapper, so skip building the entire library only to rebuild it again via the amalgamation.
jgriffiths
force-pushed
the
build_fixes
branch
from
October 31, 2023 13:36
9b1d0a1
to
ac82722
Compare
jgriffiths
force-pushed
the
build_fixes
branch
from
November 1, 2023 01:36
ac82722
to
1771250
Compare
Due to how secp now handles dllexport, it is no longer possible to build static and shared libraries under windows in a single invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-v1.0 fixes.
Fixes #388