Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More build updates #429

Merged
merged 10 commits into from
Nov 2, 2023
Merged

More build updates #429

merged 10 commits into from
Nov 2, 2023

Conversation

jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented Oct 30, 2023

Pre-v1.0 fixes.

Fixes #388

Non-ABI builds are intended only for embeddded systems such as
HWW/homebrew devices, and aren't supported by wrapped languages.

Note that the tests for this configuration are supported; users
can still verify the library functionality for this build config.
Use the now-exposed transaction member accessors so that the test
does not rely on the binary layout of the transaction struct which
changes when the Elements ABI is disabled.
@jgriffiths jgriffiths force-pushed the build_fixes branch 4 times, most recently from 34d27b7 to 9b1d0a1 Compare October 31, 2023 13:17
Notably, secp no longer uses a generated config header, and embedded builds
need to #define the modules they wish to use.

Remove unused config #define references, and use warning #pragmas
to avoid warnings rather than dummy functions.

For the windows build/batch files, build using the amalgamation rather than
having to define a large number of config defines on the command line.
Use the above changes to greatly simplify both windows wheel builds and
building wally as a DLL.
We only need our config.h and the swig wrapper, so skip building the
entire library only to rebuild it again via the amalgamation.
Due to how secp now handles dllexport, it is no longer possible to build
static and shared libraries under windows in a single invocation.
@jgriffiths jgriffiths merged commit 342bf2d into master Nov 2, 2023
4 checks passed
@jgriffiths jgriffiths deleted the build_fixes branch November 2, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose transaction accessors
1 participant